Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add bazel jobs #232

Merged
merged 2 commits into from
Mar 10, 2022
Merged

ci: Add bazel jobs #232

merged 2 commits into from
Mar 10, 2022

Conversation

Mizux
Copy link
Collaborator

@Mizux Mizux commented Mar 9, 2022 •
edited
Loading

  • [optional] Use git_repository() to retrieve dependencies
  • Add amd64 Linux Bazel based build jobs.

@Mizux Mizux added the misc non user facing: internal, cleanup, ci, release process label Mar 9, 2022
@Mizux
Copy link
Collaborator Author

Mizux commented Mar 9, 2022

MacOS and Windows are currently broken. I think it's an issue in our BUILD files not in jobs...

@gchatelet
Copy link
Collaborator

gchatelet commented Mar 10, 2022 •
edited by Mizux
Loading

As discussed offline let's:

  • remove the build part and keep only test
  • remove the -c opt
  • split the PR in three, one for Linux that we can submit right away and two branches for Mac and Windows so we can fix them

@Mizux Mizux closed this Mar 10, 2022
@Mizux Mizux reopened this Mar 10, 2022
@Mizux
Copy link
Collaborator Author

Mizux commented Mar 10, 2022

@gchatelet PTAL

note: I've just added the branch bazel/windows and bazel/macos feel free to commit in it to test/fix/iterate etc...

@gchatelet gchatelet merged commit 49679ea into google:main Mar 10, 2022
@gchatelet
Copy link
Collaborator

LGTM Thx!

@gchatelet gchatelet linked an issue Mar 10, 2022 that may be closed by this pull request
Bazel build support #221
Open
@gchatelet gchatelet added this to the v0.8.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
misc non user facing: internal, cleanup, ci, release process
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Bazel build support
2 participants
@Mizux @gchatelet